feat: add remote env to node env manager #2732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move createFeatureEnvironmentsMapping to cli (where it's used) move files and imports accordingly
barak007
approved these changes
Jul 1, 2025
Collaborator
barak007
left a comment
barak007
left a comment
There was a problem hiding this comment.
looking good. hard to know if the socket connect is good without running the app. I assume you run dev and it's fine.
Collaborator
|
we should go with major. let me know if you want me to release it |
AviVahl
reviewed
Jul 2, 2025
| env.endpointType === 'single' ? env.env : `${envName}/${this.envInstanceIdCounter.next(envName)}`; | ||
| const worker = runWorker(envInstanceId, this.createEnvironmentFileUrl(envName), runtimeOptions); | ||
| const runningEnv = await connectWorkerToProxyCom(envName, worker, forwardingCom); | ||
| let runningEnv; |
AviVahl
reviewed
Jul 2, 2025
| }); | ||
| }); | ||
|
|
||
| function getClientComm(port: number) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devServerPorttoenginePort