feat(communication): implement reconnect for websockets client/node hosts #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barak007
approved these changes
Nov 5, 2025
Contributor
|
It's not closing... Specific to this branch (not in main). |
otherwise timers don't get cleaned up properly
previously, the unstable socket.id was used to identify a client. now clients pass a stable uuid they generate during code evaluation.
the delay is used as grace time to be able to reconnect
AviVahl
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces needed improvements to the websocket client-server communication, especially around client reconnections and resource cleanup. The changes implement a stable client identification mechanism, delayed disposal of client resources to handle transient disconnects, and improved test coverage for these scenarios.
WebSocket client and server:
stableClientId) toWsClientHost, sent during authentication, enabling the server to reliably identify and manage reconnecting clients.WsServerHostnow tracks clients using the stable client ID, namespaces environment IDs, and implements delayed disposal logic. If a client disconnects, a timer is started; if the client reconnects before the timer expires, disposal is canceled, otherwise, dispose messages are emitted for all associated env IDs.API and Event:
subscribersevent emitter onWsClientHostnow includes aconnecteventdisconnectevent provides a reason string.disconnectSocket,reconnectSocket, andisConnectedhave been added for explicit socket control and connection status checks.Tests:
node-com.unit.tsto cover reconnection scenarios, delayed dispose logic, and to ensure communication remains functional after reconnects or disposes.