Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for INNODB_METRICS #19

Open
grypyrg opened this issue Jun 25, 2014 · 8 comments
Open

Add support for INNODB_METRICS #19

grypyrg opened this issue Jun 25, 2014 · 8 comments

Comments

@grypyrg
Copy link

grypyrg commented Jun 25, 2014

It would be good to add support for information_schema.INNODB_METRICS: http://dev.mysql.com/doc/refman/5.6/en/innodb-metrics-table.html

@art-spilgames
Copy link
Contributor

Thanks for the suggestion!
I'm going to pick this up today and see how easy it should/would be to implement something different than key/value.

@thijsdezoete
Copy link
Contributor

@art-spilgames I'm looking forward to your findings! :)

@art-spilgames
Copy link
Contributor

Hi Kenny,

I actually got it working in a crude way by adding only a few lines to the config in the mysql section:
stats_types = innometrics
query_innometrics = select NAME,COUNT from information_schema.INNODB_METRICS where STATUS='enabled'
interval_innometrics = 10000

This should enable you to pick up the metrics under the innometrics container but you should be able to rename it to any container you like.

There is a ton of other information in the innodb_metrics, but the question is how to make use of that. We could implement a preprocessor for the innodb_metrics table, however then we need to have a clear idea what metrics would be interesting.

@thijsdezoete
Copy link
Contributor

hi @grypyrg,

Could you let us know if @art-spilgames's suggestion solved the problem?

@grypyrg
Copy link
Author

grypyrg commented Jul 3, 2014

I don't necessarily have a problem that needs to be resolved. Just want to make sure that the necessary data is collected.

It's great that this can be solved with some configuration.
Can this be enabled by default so those metrics are collected automatically?

I think count is enough. The other columns look less interesting to me.

@art-spilgames
Copy link
Contributor

Currently there is no logic in the application about which versions support what metrics as we wanted it to keep it as simple as possible.
Perhaps a good idea to make a couple of sample configs per MySQL version and functionality?

@thijsdezoete
Copy link
Contributor

👍

@grypyrg
Copy link
Author

grypyrg commented Jul 3, 2014

I can try to help and find out. I'll add it to my todo list, but it won't have big priority so might take a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants