Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Empty object check to fix primary key constraint #32

Merged
merged 1 commit into from
May 17, 2022
Merged

fix: Empty object check to fix primary key constraint #32

merged 1 commit into from
May 17, 2022

Conversation

brookiel
Copy link
Contributor

Fix for #31.

@wzrdtales
Copy link
Member

good catch. please make sure DOO and and the commit message are in line and add a test once so this doesn't happen again

@brookiel brookiel changed the title Empty object check to fix primary key constraint fix: Empty object check to fix primary key constraint Aug 14, 2021
@brookiel brookiel force-pushed the master branch 2 times, most recently from bd2c783 to 4fe4af5 Compare August 14, 2021 04:33
@brookiel
fix: addColumn should allow primary key constraint
716dcb9 
Signed-off-by: Brooke Leddy <bleddy@gmail.com>
@brookiel
Copy link
Contributor Author

Should be good to go now!

@brookiel
Copy link
Contributor Author

@wzrdtales Are we able to merge this one now?

@wzrdtales wzrdtales merged commit 851d4fe into db-migrate:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brookiel @wzrdtales