Generating a migration script using the programmable API does not use the name provided in the arguments

[andyautida14]

I'm submitting a...

• Bug report
• Feature request
• Question

Current behavior

The migrationName parameter provided on create method of the programmable API is ignored when creating a migration. It instead uses the first command-line argument as the name.

Expected behavior

Use the migrationName parameter passed to the create method as the name of the new migration.

Minimal reproduction of the problem with instructions

index.js:

const program = require('commander')
const dbMigrate = require('db-migrate')

program
  .command('migration <name>')
  .description('create a new migration script')
  .action(async function(name) {
    console.log('name:', name)
    const instance = dbMigrate.getInstance(true)
    await instance.create(name)
  })

program.parse(process.argv)

running the command above will produce the following output:

$ DATABASE_URL=postgres://localhost:5432/sample node . migration this-should-be-the-name-of-migration
name: this-should-be-the-name-of-migration
[INFO] Created migration at /Users/user/db-migrate-bug/migrations/20191014092749-migration.js

The filename produced is the same as the one logged above.

What is the motivation / use case for changing the behavior?

to be able to create migration files with correct file names programmatically

Environment

db-migrate version: 0.11.6
db-migrate-pg version: 1.0.0

Additional information:
- Node version: v12.7.0
- Platform:  Mac




---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/82208238-generating-a-migration-script-using-the-programmable-api-does-not-use-the-name-provided-in-the-arguments?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[andyautida14]

Any updates on this?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[wzrdtales]

This is due to the following

node-db-migrate/lib/commands/create-migration.js

Line 51 in bd165a5

internals.argv.title = internals.argv._.shift();

This is shifting out the variable, while this is pushing in

node-db-migrate/api.js

Line 332 in bd165a5

this.internals.argv._.push(migrationName);

needs to be fixed in the api.js

thank you for reporting!