-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #468: avoid connecting to database before creation. #644
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
* avoid connecting to database before creation. Signed-off-by: Wenshan Ren <renws1990@gmail.com>
Could you please have a review @wzrdtales? |
@wzrdtales ping |
I had the same problem, I tested the change that he did and works well. |
@RenWenshan Thank you, this worked for me. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Comment to keep this PR open |
sry, i completely drowned in work. this should work in most cases, not sure about some of the other more special cases. But since those are broken right now anyways, I will merge this. |
Hi @wzrdtales! Would yo mind releasing this? And probably add to v1.0.0 as well? |
fix #468