Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #468: avoid connecting to database before creation. #644

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

RenWenshan
Copy link
Contributor

@RenWenshan RenWenshan commented Aug 14, 2019

fix #468

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: ffcdab7
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

* avoid connecting to database before creation.

Signed-off-by: Wenshan Ren <renws1990@gmail.com>
@RenWenshan
Copy link
Contributor Author

Could you please have a review @wzrdtales?

@RenWenshan
Copy link
Contributor Author

@wzrdtales ping

@archagy
Copy link

archagy commented Oct 18, 2019

I had the same problem, I tested the change that he did and works well.

@jesseteal
Copy link

@RenWenshan Thank you, this worked for me.

@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 10, 2019
@stale stale bot closed this Dec 17, 2019
@RenWenshan
Copy link
Contributor Author

Comment to keep this PR open

@wzrdtales wzrdtales reopened this Feb 3, 2020
@stale stale bot removed the stale label Feb 3, 2020
@wzrdtales
Copy link
Member

sry, i completely drowned in work.

this should work in most cases, not sure about some of the other more special cases. But since those are broken right now anyways, I will merge this.

@wzrdtales wzrdtales merged commit 2d6878c into db-migrate:master Feb 3, 2020
@ZsoltPath
Copy link

Hi @wzrdtales!

Would yo mind releasing this? And probably add to v1.0.0 as well?
Do you know when could this happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db-migrate db:create not working as intended
5 participants