Skip to content

refactor(tabs): integrate v2 design #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 6, 2024

Conversation

mfranzke
Copy link
Member

closes db-ux-design-system/core#85

Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/refactor-tabs-integrate-v2-design

@mfranzke mfranzke marked this pull request as ready for review July 23, 2024 13:36
@mfranzke mfranzke enabled auto-merge (squash) July 23, 2024 13:40
@mfranzke mfranzke disabled auto-merge July 24, 2024 08:06
@mfranzke mfranzke added visual breaking changes We expect visual breaking changes within the consuming websites. community feedback labels Jul 25, 2024
@mfranzke mfranzke removed their assignment Jul 30, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 2, 2024
@mfranzke mfranzke changed the base branch from main to release-candidate August 2, 2024 13:13
@mfranzke mfranzke merged commit 87cbce2 into release-candidate Aug 6, 2024
7 checks passed
@mfranzke mfranzke deleted the refactor-tabs-integrate-v2-design branch August 6, 2024 09:18
@mfranzke mfranzke mentioned this pull request Aug 6, 2024
mfranzke added a commit that referenced this pull request Aug 6, 2024
* refactor(tabs): integrate v2 design

closes db-ux-design-system/core#85

Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>

* refactor: corrected styling

Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>

* feat: added icon

* refactor: added small size

* feat: added small items with icons

* refactor: added correct color value

* refactor: button vertical alignment

* refactor: added pressed state

* Update tab-bar.scss

* refactor: simplification

* Update tab-bar.scss

* refactor: added missing parameter

* refactor: add relevant comment

* refactor: simply enabled multi-line content

* style: feedback

* refactor: we don't want to advertise for this one

* style: adaptions out of feedback

* refactor: corrected these declarations

---------

Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com>
@mfranzke mfranzke added the 🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community feedback 🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders documentation Improvements or additions to documentation improvement patterns visual breaking changes We expect visual breaking changes within the consuming websites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diskrepanz zwischen Sketch Design und Frontend Komponente
3 participants