-
Notifications
You must be signed in to change notification settings - Fork 5
refactor(tabs): integrate v2 design #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mfranzke
merged 22 commits into
release-candidate
from
refactor-tabs-integrate-v2-design
Aug 6, 2024
Merged
refactor(tabs): integrate v2 design #895
mfranzke
merged 22 commits into
release-candidate
from
refactor-tabs-integrate-v2-design
Aug 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes db-ux-design-system/core#85 Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>
🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/refactor-tabs-integrate-v2-design |
Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com>
…m/db-ui/core into refactor-tabs-integrate-v2-design
Merged
mfranzke
added a commit
that referenced
this pull request
Aug 6, 2024
* refactor(tabs): integrate v2 design closes db-ux-design-system/core#85 Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com> * refactor: corrected styling Co-Authored-By: Nicolas Merget <104347736+nmerget@users.noreply.github.com> * feat: added icon * refactor: added small size * feat: added small items with icons * refactor: added correct color value * refactor: button vertical alignment * refactor: added pressed state * Update tab-bar.scss * refactor: simplification * Update tab-bar.scss * refactor: added missing parameter * refactor: add relevant comment * refactor: simply enabled multi-line content * style: feedback * refactor: we don't want to advertise for this one * style: adaptions out of feedback * refactor: corrected these declarations --------- Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community feedback
🪩 🔥 🕺 cool topic
some relevant topics, that we even also need to report in different rounds / to stakeholders
documentation
Improvements or additions to documentation
improvement
patterns
visual breaking changes
We expect visual breaking changes within the consuming websites.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes db-ux-design-system/core#85