Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add labelVariant=hidden for input, select, textarea #1809

Merged
merged 10 commits into from
Nov 13, 2023
Merged

feat: add labelVariant=hidden for input, select, textarea #1809

merged 10 commits into from
Nov 13, 2023

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Nov 10, 2023 •
edited by mfranzke
Loading

Proposed changes

  • add labelVariant Prop for input, select, textarea
  • refactored labelHidden for checkbox and radio to match with labelVariant

Resolves #1712

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Nov 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-label-variant-hidden

@nmerget nmerget enabled auto-merge (squash) November 10, 2023 08:43
@mfranzke mfranzke changed the title feat: add labelVariant=hidden for input, select, textarea feat: add labelVariant=hidden for input, select, textarea Nov 10, 2023
mfranzke
mfranzke previously approved these changes Nov 10, 2023
View reviewed changes
@nmerget nmerget merged commit 38c7f8e into main Nov 13, 2023
29 checks passed
@nmerget nmerget deleted the feat-label-variant-hidden branch November 13, 2023 15:21
@mfranzke mfranzke removed the request for review from dkolba November 13, 2023 15:23
@mfranzke mfranzke removed the request for review from annsch November 13, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

Assignees
No one assigned
Labels
🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form elements: Provide possibility to visually hide the label
2 participants
@nmerget @mfranzke