Engine Addition: NuSQUIDS #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+287
to
+290
| ExternalProject_Add(NUSQUIDS | ||
| GIT_REPOSITORY https://github.com/arguelles/nuSQuIDS.git | ||
| GIT_TAG master | ||
| BINARY_DIR = <SOURCE_DIR> |
There was a problem hiding this comment.
nuSQuIDS is actually being developed. Is it worth to use tag etc. instead of master?
There was a problem hiding this comment.
The tagging system being used by NuSQUIDS is not clear.. the tags are much older than recent developments, some of which are required for the planned quantum decoherence studies planned. It might be worth pulling an individual git commit hash if that's possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description:
Add NuSQUIDS engine into NuOscillator. Implementation is not filled. This is a draft PR to test the CI/CD for NuSQUIDS
Changes or fixes:
Examples: