Feature/add final sql check setting #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelPancocha
commented
Nov 26, 2021
| return u.user_permissions.values_list('codename', flat=True) | ||
|
|
||
| @with_final_sql_check | ||
| def test_many_to_many_when_sql_check(self): |
There was a problem hiding this comment.
@dbartenstein please confirm, this is how it should have looked :)
| @@ -0,0 +1,44 @@ | |||
| import logging | |||
There was a problem hiding this comment.
@Fasther: wouldn’t name file tests_decorators.py as it suggests that it contains tests. Better go with decorators.py.
There was a problem hiding this comment.
@dbartenstein I did it on purpose - all tests are in files without "tests" but the utils live in "tests_utils" where are no tests :)
|
@dbartenstein all tests run for me OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add setting
CACHALOT_FINAL_SQL_CHECK+ create & adapt tests