Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docs and tests #2

Merged
merged 2 commits into from
Dec 27, 2021
Merged

Conversation

PavelPancocha
Copy link
Collaborator

  • Fix failing test on Django 4.0
  • Add docs & changelog for CACHALOT_FINAL_SQL_CHECK

@PavelPancocha PavelPancocha changed the base branch from master to feature/order_by December 27, 2021 09:33
additional_tables = []
if django_version[0] >= 4 and settings.CACHALOT_FINAL_SQL_CHECK:
# with Django 4.0 comes some query optimalizations that do selects little differently.
additional_tables.append('django_content_type')
Copy link
Owner

@dbartenstein dbartenstein Dec 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fasther can you explain why django_content_type has to be added manually?

@dbartenstein dbartenstein merged commit 38bf231 into feature/order_by Dec 27, 2021
@dbartenstein dbartenstein deleted the feature/docs_and_tests branch December 27, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants