Clean up testing config files.

[tsroten]

Description

This moves the configuration from .coveragerc, pytest.ini, and conftest.py into the existing setup.cfg so we don't have our configuration scattered across so many files.

conftest.py is useful when you need to ignore files during testing based on dynamic criteria (like Python version or operating system) -- which we don't need to do (as of right now).

Checklist

• I've added this contribution to the changelog.md. not needed
• I've added my name to the AUTHORS file (or it's already there).

[codecov-io]

Codecov Report

Merging #431 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #431      +/-   ##
========================================
- Coverage   77.02%    77%   -0.02%     
========================================
  Files          22     20       -2     
  Lines        2472   1879     -593     
========================================
- Hits         1904   1447     -457     
+ Misses        568    432     -136

Impacted Files	Coverage Δ
mycli/completion_refresher.py	94.73% <0%> (-5.27%)	⬇️
mycli/__init__.py

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9d916...c606deb. Read the comment docs.

[tsroten]

Looks like the code coverage isn't quite working, yet.

[meeuw]

This is a nice clean up! I think something goes wrong because the pytest-cov doesn't do the parallel execution or it doesn't combine the output correctly.

[tsroten]

@meeuw Thanks! Removing pytest-cov still has the same code coverage problem (see latest test). It looks like the coverage gap is in code that behave would have executed. I wonder if the COVERAGE_PROCESS_START doesn't support setup.cfg. I'll look into it a bit more.

[meeuw]

I've pinpointed the problem to test/features/environment.py where you've changed .coveragerc to setup.py. I think coverage doesn't recognize setup.cfg's [coverage:run] for COVERAGE_PROCESS_START.

After running behave you should see a lot of .coverage* files (if it's using parallel = True), now there is only one .coverage (parallel = False).

[tsroten]

Switching it to run works. However, I can't get it to work when running behave from the project directory, only the test directory. Very odd.

What I mean is, behave runs fine from both directories, but coverage is logged only when behave is called from the test directory.

[meeuw]

That is caused by cwd='..' in

mycli/test/features/steps/wrappers.py

Line 41 in 1136a1f

context.cli = pexpect.spawnu(cmd, cwd='..')

😊

[tsroten]

Yes! thanks for pointing that out. Now that I looked, I had tons of .coverage* files outside of my mycli folder because it was storing them outside of the project directory. Switching that to an absolute path now works.

[meeuw]

👍 do you want pytest-cov back? Maybe it works if we first run the behave tests and then pytest-cov?
I think it's a good idea to sent a bug report for python-coverage (for .coveragerc / setup.cfg), please let me know if you've already done that.

[tsroten]

@meeuw Sure, I added it back. I think this is ready to be merged, what do you think?

[meeuw]

👍 very nice