Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Hyp3 integration #473

Merged
merged 16 commits into from
Jan 19, 2023
Merged

Conversation

forrestfwilliams
Copy link
Contributor

@forrestfwilliams forrestfwilliams commented Jan 18, 2023

To support RAiDER processing of GUNW's in HyP3, we need:

  • to download the GUNW from S3
  • Replace the GUNW in S3 with an updated version including the tropospheric corrections

which is all handled via the new RAiDER.aws module (adds boto3 as a dependency)

This PR changes the GUNW interface to:

  • make file argument optional --file
  • if --file is not provided:
    • and a --bucket argument is provided: download GUNW from S3
    • and a --bucket argument is not provided: throw an error
  • changes the --model argument to --weather-model
  • replaces _ with - in arguments. E.g., --output-directory instead of --output_directory (argparse automatically casts - to _ in argument variable names)

This PR also

  • changes the Docker entrypoint from bash to raider.py
  • Fixes next version number in Changelog
  • removes a bunch of unused imports

Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! There's still some work around logging, and the boto3 needs to be added to the environment.yml file

tools/RAiDER/cli/raider.py Outdated Show resolved Hide resolved
tools/RAiDER/cli/raider.py Outdated Show resolved Hide resolved
@jhkennedy jhkennedy marked this pull request as ready for review January 18, 2023 23:37
Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to run the GUNW entrypoint against a file in S3 both directly and with the Docker container. I think this is ready at this point.

@jhkennedy jhkennedy merged commit 5e93946 into dbekaert:dev Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants