-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unit tests #609
Update unit tests #609
Conversation
f960fff
to
e17a491
Compare
5a1a3e4
to
70a663d
Compare
@dbekaert the checks will pass once the ESA_USERNAME and ESA_PASSWORD environment variables are added to CircleCI so that orbits can be downloaded. I also decided to not use GitHub Actions as CircleCI handles forks better. You can remove the repository secrets I had you add earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think once that's integrated it resolves the other issue, too.
Feeding all of this orbit junk at once.
Co-authored-by: Charlie Marshak <cmarshak@users.noreply.github.com>
Co-authored-by: Charlie Marshak <cmarshak@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done |
This PR:
updates CircleCI config to test across multiple Python versions (3.9-3.12)
coveralls
on Python 3.12removes unnecessary imports in
cli/__main__.py
Ensures all type hints are compatible with Python 3.9
updates loading entrypoints for Python 3.12, fixes Need to upgrade importlib.metadata.entry_points for Python 3.12 #607
re-orders
environment.yml
so that packages are in the correct section and listed alphabetically❗ marks all tests in
test_temporal_interpolate.py
as "long" to prevent them from running in CI due totest/test_temporal_interpolate.py
fail due to an HTTP 301 Moved Permanently Error #611Updates
sentineleof
to version 9 or greater, fixes [BUG] Sentinel-1 ESA Orbit Availability and Rate Limiting #610sentineleof
also now returns paths instead of strings, so_get_acq_time_from_gunw_id
and tests were updated accordinglyAdds an
_ensure_orbit_credentials
function inprepFromGUNW.py
to ensure ESA CDSE credentials are in~/.netrc
or provided via environment variablesNote: For this one, I wanted to put this in
models/credentials.py
so all credentials were handled in the same place, but everything there is related to acquiring weather models so it didn't make sense to stuff it in there without a significant refactor.drops
hyp3lib
in favor ofsentineleof
asget_orb
was the only thing being used fromhyp3lib
Adds a
setup_from_env
function tomodels/credentials.py
which will pull all credentials needed for acquiring weather model data from environment variables and ensure the correct config file is written. This makes setting up credentials in CI pipelines significantly easier.Note: This could also have a command line interface, but I couldn't decide if it was worth it.