Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add None checks to aws.get_s3_file #658

Merged
merged 12 commits into from
Jul 9, 2024

Conversation

garlic-os
Copy link
Contributor

@garlic-os garlic-os commented Jun 26, 2024

Description

Adds a check to ensure the value returned from aws.get_s3_file is not None in every place that it is used. If the value is None, execution is halted with an error message that better explains what went wrong.

Motivation and Context

Fixes #648.

How Has This Been Tested?

Added regression tests to ensure the proper messages are shown when a GUNW file is not produced. (TO DO)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@garlic-os garlic-os marked this pull request as ready for review July 7, 2024 01:39
Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlmaurer jlmaurer merged commit e37c73c into dbekaert:dev Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad error message when GUNW file missing in S3 bucket
2 participants