Bug fixes and unit test updates #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlmaurer
force-pushed
the
fix_gnss_download
branch
from
5baeeb1
to
50b04f5
Compare
jlmaurer
force-pushed
the
fix_gnss_download
branch
from
50b04f5
to
a826e07
Compare
cmarshak
approved these changes
Jul 5, 2024
| @@ -1487,7 +1492,7 @@ def fitfunc(t): | |||
| phsfit_c[station] = pcov[2, 2]**0.5 | |||
| # pass RMSE of fit | |||
| seasonalfit_rmse[station] = yy - custom_sine_function_base(tt, *popt) | |||
| seasonalfit_rmse[station] = (scipy_sum(seasonalfit_rmse[station]**2) / | |||
| seasonalfit_rmse[station] = (np.sum(seasonalfit_rmse[station]**2) / | |||
There was a problem hiding this comment.
This is all I can review as I don't know what else you made changes to - looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some documented bugs and adds unit tests to increase total coverage
Description
scipy.sumin RAiDER stats #649 scipy.sum depracation errorraiderDownloadGNSS.pyraiderDownloadGNSS.py,raiderStats.py, and ***.Motivation and Context
Fixes #649
How Has This Been Tested?
Unit tests added and all tests pass locally
Type of change
Checklist: