Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply patches and fixes from similar actions #31

Merged
merged 4 commits into from
Jul 28, 2023
Merged

apply patches and fixes from similar actions #31

merged 4 commits into from
Jul 28, 2023

Commits on Jul 28, 2023

  1. add checkstyle cmd default parameters

    @dbelyaev
    dbelyaev committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    ca57ba1 View commit details
    Browse the repository at this point in the history

  2. add properties_file option 

    # Conflicts:
#	action.yml
#	entrypoint.sh
    @tochi-y @dbelyaev
    tochi-y authored and dbelyaev committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    a91e58c View commit details
    Browse the repository at this point in the history

  3. update entrypoint.sh to take care of possible network\installation is… 

    …sues and timeouts

Add precondition detection:
The installation of reviewdog in the container will fail if there is a network timeout. Therefore, if reviewdog does not exist, exit directly to avoid finding the problem after downloading checkstyle, which is a waste of time.

Downloading checkstyle theory also takes time. Before time-consuming operation (non-real-time response), output log feedback current process.
# Conflicts:
#	entrypoint.sh
    @kerwin612 @dbelyaev
    kerwin612 authored and dbelyaev committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    bc38f54 View commit details
    Browse the repository at this point in the history

  4. clean-ups 

    adjust logs
fix copy-paste error
    @dbelyaev
    dbelyaev committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c1923ae View commit details
    Browse the repository at this point in the history