Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export combinators for use in other parser combinators #10

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

mwhitworth
Copy link
Contributor

so that we can incorporate these top-level combinators in other grammars

@mwhitworth
Copy link
Contributor Author

@dbernheisel - would it be possible to make a release including this fix? It would be required for a new version of my library relative_datetime to be published

@dbernheisel
Copy link
Owner

Heyo, I'm not at my computer to make the change for this week, so the earliest I can do it is probably Friday or this weekend.

@dbernheisel
Copy link
Owner

I'm ok to merge this, but since they're exported/public I'll also want to document that these are not part of the API and can break upon any release. The combinators are likely to change every release.

@mwhitworth
Copy link
Contributor Author

I'll add a header comment to that effect, and fix the unverified commit.

@mwhitworth
Copy link
Contributor Author

Documentation options for defparsec are limited (to achieve this goal), since it generates its own @doc function and there are no options to control @doc for either the wrapper function or the combinator.

@dbernheisel
Copy link
Owner

The module is already @moduledoc false so this should be good enough

@dbernheisel dbernheisel merged commit 3f853ed into dbernheisel:main Dec 6, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants