Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Duplicate in Firefox #6

Open
helfi92 opened this issue Dec 27, 2018 · 3 comments
Open

[Bug] Duplicate in Firefox #6

helfi92 opened this issue Dec 27, 2018 · 3 comments

Comments

@helfi92
Copy link

helfi92 commented Dec 27, 2018

We are using this library to display a terminal. It works properly on Chrome but noticed that anything on the page gets duplicated in Firefox:

Terminal on Chrome

screen shot 2018-12-27 at 12 31 44 pm

Terminal on FF

screen shot 2018-12-27 at 12 32 21 pm

I believe the culprit lies in hterm.ScrollPort.prototype.decorate:

hterm.ScrollPort.prototype.decorate = function(div) {
  // ...

  if ('mozInnerScreenX' in window)  // detect a FF only property
    this.iframe_.src = '#';

 // ...

Having the iframe src be # will duplicate whatever is on the page, including all the headers defined on the page consuming this library.

@helfi92
Copy link
Author

helfi92 commented Jan 14, 2019

@dbkaplun Any idea of what would be a good fix for this issue?

@pablodgonzalez
Copy link

i am over the same issue. The problem is about the iframe.src property in FF.
is it is '' => FF says current location and if it is '#' => firefox say currentlocation#
In the case of hterm the src is loaded after the contentDocument so hterm creates the terminal and FF delete it and write the current location.
I have tried putting all about contentDocument in the iframe's load event, but It hasn't work until now.
please, if someone find a good fix it will be great

@helfi92 helfi92 changed the title [Bug] Duplicate in FF [Bug] Duplicate in Firefox Feb 7, 2019
@denlap007
Copy link

Is there any workaround available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants