Remove duplicate navigation bars

[helfi92]

STR:

1. Navigate to http://localhost:5080/shell

Actual: There are 2 navigation bars on the left

Expected: There is 1 navigation bar on the left

[arshadkazmi42]

I can take this up.

[helfi92]

Go for it.

[arshadkazmi42]

I started looking into this.
look's like its failing only in firefox. Its working fine in chrome.

Any tips, where should I look for this issue? I tried debugging in Shell component and view.

[helfi92]

Indeed, this is really strange. I think the problem is in this file https://github.com/taskcluster/taskcluster-web/blob/master/src/components/Shell/index.jsx

[arshadkazmi42]

Looks like its due to this
ref={this.registerChild} I am still trying to find the exact issue.

I think the component is rendering twice

[helfi92]

Looks like its due to this ref={this.registerChild}

I agree.

[arshadkazmi42]

So I narrowed down the issue.
In firefox, componentDidMount is getting called twice, due to which its rendering two times.
Also, in chrome, componentDidMount is getting called only once.
I am trying to figure out why this happens.

[helfi92]

I looked into it and believe there is a bug in the hterm library. I created dbkaplun/hterm-umdjs#6.

[arshadkazmi42]

@helfi92 Ok. I think once that is merged, it will fix this issue also.

[helfi92]

Continued in taskcluster/taskcluster#217.