Added IEX::Resources::OHLC#get and IEX::Resources::OHLC#market #5
Conversation
jromanovs
force-pushed
the
stock-market-ohlc
branch
from
4e9e0b0
to
e0b4c46
Compare
CHANGELOG.md
Outdated
|
|
||
| * Your contribution here. | ||
|
|
||
| ### 0.3.3 (2018/06/12) | ||
|
|
||
| * [#5](https://github.com/dblock/iex-ruby-client/pull/5): Reticulated splines - [@jromanovs](https://github.com/jromanovs). |
There was a problem hiding this comment.
Lol, that should probably not say Reticulated splines ;)
CHANGELOG.md
Outdated
| @@ -1,7 +1,13 @@ | |||
| ### 0.3.3 (Next) | |||
| ### 0.3.4 (Next) | |||
There was a problem hiding this comment.
Leave the version alone, 0.3.3 has not been released and so your changes should just live under next.
CHANGELOG.md
Outdated
|
|
||
| * [#5](https://github.com/dblock/iex-ruby-client/pull/5): Reticulated splines - [@jromanovs](https://github.com/jromanovs). | ||
| * Added `IEX::Resources::OHLC#get` - [@jromanovs](https://github.com/jromanovs). | ||
| * Added `IEX::Resources::OHLC#market` - [@jromanovs](https://github.com/jromanovs). |
There was a problem hiding this comment.
Add the PR number here like above.
README.md
Outdated
| @@ -43,6 +43,33 @@ quote.change_percent_s # '+0.42%' | |||
|
|
|||
| See [#quote](https://iextrading.com/developer/docs/#quote) for detailed documentation or [quote.rb](lib/iex/resources/quote.rb) for returned fields. | |||
|
|
|||
| ### Get a OHLC price | |||
|
|
|||
| Fetches a single stock OHLC price. Open and Close prices contain timestamp. | |||
lib/iex/resources/ohlc.rb
Outdated
| response = IEX::Api::OHLC.market | ||
| response.each do |key, value| | ||
| response[key] = OHLC::Base.new(value) | ||
| end |
There was a problem hiding this comment.
You should probably create another hash instead of modifying the existing one, I am going to guess it's faster and cleaner, so:
response = Hash[IEX::Api::OHLC.market.map do |k, v|
[k, OHLC::Base.new(v)]
end]
| module IEX | ||
| module Resources | ||
| module OHLC | ||
| class PriceTimed < Resource |
There was a problem hiding this comment.
Feels like TimedPrice sounds better, unless it's a term from IEX.
…lained, fix and add PR in changelog
jromanovs
force-pushed
the
stock-market-ohlc
branch
from
e0b4c46
to
4d55a8d
Compare
|
Sorry, if it is a newbie questions. I was commit all requested changes. Does it required any more actions from my side? Or just wait when you have a chance to apply changes? Does it need to invest from myself some more time to extend functionality? I am curious, because found that market prices provided by IEX Group API is far from best or may be I miss something. Have a good day :) |
|
Sorry just seeing this, github doesn't notify on updates. Changes merged. |
|
@jromanovs Interested in helping out with this library? Maybe make the next release? If yes sign up on rubygems.org and lmk which email address you used. |
|
@jromanovs see question above on helping with releases? ^ |
|
Sorry, was busy with other projects. I was registered @ ruby gems.org as with email jromanovs@gmail.com. Hope that can be helpful on next week. I was already started another feature for bulk requests. I have a plans to make some commits on next week and then be happy to help with next release. How about such plan? |
|
Sounds great! Thanks. Added you to Rubygems and invited you to the project, https://github.com/dblock/iex-ruby-client/invitations |
Add ability to gather stock OHLC prices as well for all market. Hope you will find those changes helpful.