Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties for key stats API #50

Merged
merged 1 commit into from
May 6, 2019

Conversation

bingxie
Copy link
Collaborator

@bingxie bingxie commented May 6, 2019

Address to issue: #49

Add missing properties for key stats API:

Missing properties list:

      property 'employees'
      property 'avg_10_volume', from: 'avg10Volume'
      property 'avg_30_volume', from: 'avg30Volume'
      property 'ttm_dividend_rate', from: 'ttmDividendRate'
      property 'max_change_percent', from: 'maxChangePercent'
      property 'day_30_change_percent', from: 'day30ChangePercent'
      property 'day_30_change_percent_s', from: 'day30ChangePercent', with: ->(v) { Resource.float_to_percentage(v) }
      property 'next_dividend_date', from: 'nextDividendDate'
      property 'next_earnings_date', from: 'nextEarningsDate'
      property 'pe_ratio', from: 'peRatio'
      property 'beta'

@bingxie bingxie force-pushed the add-missing-properties-for-key-stats-api branch 2 times, most recently from 2f05f34 to cedaffd Compare May 6, 2019 11:05
@bingxie bingxie requested a review from dblock May 6, 2019 11:06
@bingxie bingxie force-pushed the add-missing-properties-for-key-stats-api branch from cedaffd to 11dd235 Compare May 6, 2019 12:05
@dblock dblock merged commit b245638 into master May 6, 2019
@bingxie bingxie deleted the add-missing-properties-for-key-stats-api branch May 9, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants