Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stock_market_list #65

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Add stock_market_list #65

merged 1 commit into from
Mar 9, 2020

Conversation

bguban
Copy link
Collaborator

@bguban bguban commented Mar 4, 2020

No description provided.

@dangerpr-bot
Copy link

dangerpr-bot commented Mar 4, 2020 •
edited
Loading

1 Warning
⚠️ [DEPRECATION] check is deprecated. Please use check! instead.

Generated by 🚫 Danger

@bguban bguban force-pushed the list_endpoint branch 2 times, most recently from 61322a8 to c5cb445 Compare March 4, 2020 14:54
dblock
dblock requested changes Mar 4, 2020
View reviewed changes
Copy link
Owner

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be stock_market_list, since the underlying api is /stock/market/list, will make it future proof for other list APIs.

CHANGELOG.md Outdated Show resolved Hide resolved
lib/iex/endpoints/list.rb Outdated Show resolved Hide resolved
@bguban bguban changed the title Market list endpoint was added. Add stock_market_list Mar 4, 2020
@bguban
Copy link
Collaborator Author

bguban commented Mar 9, 2020

@dblock could you take a look at this PR?

@dblock dblock merged commit fb0a5c4 into dblock:master Mar 9, 2020
@dblock
Copy link
Owner

dblock commented Mar 9, 2020

👍

@bguban bguban deleted the list_endpoint branch April 10, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bguban @dangerpr-bot @dblock