Add readme documentation for advanced stats and remove extra field av… #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g30Volume since it is found in key stats
tylerhaugen-stanley
force-pushed
the
add-advanced-stats-to-readme
branch
from
d3b0b5a
to
1f65b25
Compare
dblock
reviewed
Nov 5, 2020
README.md
Outdated
| advanced_stats.forward_pe_ratio # 18.14 | ||
| advanced_stats.pe_high # 22.61 | ||
| advanced_stats.pe_low # 11.98 | ||
| advanced_stats.avg_30_volume # |
There was a problem hiding this comment.
this doesn't exist here ... remove
let's check all the fields in advanced_stats? did we miss anything else?
There was a problem hiding this comment.
Yup my bad. Will double check. Hoping to have time to clean this up tomorrow or on the weekend.
There was a problem hiding this comment.
Removed avg_30_volume. While confirming all fields are correct using the actual API call, I noticed put_call_ratio was missing so I also added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the README was missing advanced stats so I added it. Also removed one property from advanced stats that is already found in key stats.