Add support for balance sheet API endpoint #91
Conversation
…tanley/iex-ruby-client into add-balance-sheet
|
Pretty sure I didn't handle amending the commits properly, let me know if you'd like to me fix things. |
| @@ -0,0 +1,53 @@ | |||
| --- | |||
| http_interactions: | |||
There was a problem hiding this comment.
I ended up copying the majority of these fixture files from other examples but based o n the various dates throughout the files it seems as though a generator of sorts was used. Please advise if I should do things differently than I have here.
There was a problem hiding this comment.
These are not using a generator but recorded using vcr against production iex endpoints. Delete the .yml files you copied, set the tokens in your ENV and run rspec ...spec.rb without the presence of the VCR file and it will record new interactions.
If the file (e.g. msft.yml) exists, it will be used and no real HTTP request will be made. Otherwise an HTTP request is made. Also take a look at https://github.com/dblock/iex-ruby-client/blob/master/spec/support/vcr.rb of how we prevent your tokens from being written into these.
There was a problem hiding this comment.
Cool thanks for the info. I currently don't have a paid IEX account so I don't believe this will work for me since balance sheet is a premium endpoint. This seems like a common issue I imagine you have come across in the past, is there a good way around this?
There was a problem hiding this comment.
i did, no way around this, i just pay for it - maybe email them and they can give you some credits to contribute here?
There was a problem hiding this comment.
I'll just pay for the account i was planning to eventually anyway. Will look into doing this properly this weekend.
There was a problem hiding this comment.
Updated with proper fixture files.
|
Looks good, needs a rebase. |
No description provided.