Add key stat properties to advanced stats #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhaugen-stanley
force-pushed
the
add-key-stats-to-advanced-stats
branch
from
b48d992
to
340cf6a
Compare
|
Want to fix this one up? |
Should be good to go now. |
|
Thanks for all the PRs @tylerhaugen-stanley. Want to join as a co-maintainer and make the next release? Drop me an email to dblock at dblock dot org with your rubygems email/username if you do so I can add you. Also we should probably make it 1.4.0 since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Advanced Stats API call returns all key stats anyway, to save on data weighting it makes sense to add the key stat properties to the advances stat module.