Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Service_GetStatus call - addressed issues mentioned in the previous request #8

Closed
wants to merge 3 commits into from
Closed

Added Service_GetStatus call - addressed issues mentioned in the previous request #8

wants to merge 3 commits into from

Conversation

vladaver
Copy link
Contributor

No description provided.

vladaver added 2 commits April 25, 2014 12:08
@vladaver
Added Service_GetStatus call
c7da2f8 
Added Service_GetStatus call returning in the SERVICE_STATUS property
status name (one of: Stopped, Starting, Stopping, Running, Resuming,
Pausing, Paused), or Absent when service does not exist. Target service
name is provided in the SERVICE_NAME property.
@vladaver
addressed issues mentioned in pull request
37f4924
dblock
dblock reviewed Apr 28, 2014
View reviewed changes
CHANGELOG.md
@@ -1,6 +1,7 @@
### 1.5 (Next Release)

* **Features**:
* Added `Service_GetStatus`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a link to the pull request, with your name, like the other ones below.

@dblock
Copy link
Owner

dblock commented Apr 28, 2014

Thx, this is a lot better, minor comments.

@vladaver
moved service state to string conversion to ServiceInstance class, ac…
72ecc3c 
…cessible as GetServiceStateString(), + minor text changes
dblock
dblock reviewed Apr 28, 2014
View reviewed changes
CHANGELOG.md
@@ -1,6 +1,7 @@
### 1.5 (Next Release)

* **Features**:
* Added `Service_GetStatus` - (https://github.com/dblock/msiext/pull/8)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing a period :)

@dblock
Copy link
Owner

dblock commented Apr 28, 2014

This is good, I'll merge with fixing the above.

@dblock
Copy link
Owner

dblock commented Apr 28, 2014

I mean I'll take care of fixing the above.

@vladaver
Copy link
Contributor Author

Thanks.
Last minute thought - maybe call should be Service_GetState, with output to SERVICE_STATE? (instead of status)

@dblock
Copy link
Owner

dblock commented Apr 28, 2014

I merged via cd27902. I think you're right, it should be "State". Want to make another pull request on top?

@dblock
Copy link
Owner

dblock commented Apr 28, 2014

Closing this one.

@dblock dblock closed this Apr 28, 2014
@dblock
Copy link
Owner

dblock commented Apr 28, 2014

Fyi, you'll have to rebase from my master. You should make feature branches in general and keep master of the repo from which you fork in sync with your master. Also read up on squashing, I often use --amend for updating existing pull requests.

@dblock dblock mentioned this pull request Apr 29, 2014
Closed
@dblock
Copy link
Owner

dblock commented Apr 29, 2014

I opened #10 for the rename so we don't forget before releasing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladaver @dblock