This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
ci: Use 9 instead of stable node #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We indirectly depend on anodynos/upath via webpack. upath specifically states it does not support node > 9. Stable should be added back in as soon as our dependency graph has updated to address this – hopefully it will not be too long. See anodynos/upath#14 See anodynos/upath#15
lupakivan
approved these changes
Apr 25, 2018
misund
added a commit
that referenced
this pull request
Apr 26, 2018
misund
pushed a commit
that referenced
this pull request
Apr 26, 2018
|
Hello everyone - I merged anodynos/upath#15 & published it - thanks & sorry for the delay! You can update to node@10, once you check its working. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We indirectly depend on anodynos/upath via webpack. upath specifically states it does not support node > 9.
Stable should be added back in as soon as our dependency graph has updated to address this – hopefully it will not be too long.
See anodynos/upath#14
See anodynos/upath#15
Please tick a box
If you're adding a feature, is it documented in a storybook story?
Are the components you're working on reusable between brands?
If you're creating markup, did you add proper semantics?
(Did you do a CR and see that there is something that we should check for each PR, that are not on the list, please update this document)