Implemented produce-clt-manifest arguments into search, search with index, and param search #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex, and param search
yuanzhou
requested changes
Jul 10, 2024
src/app.py
Outdated
| @@ -247,6 +248,56 @@ def search(self): | |||
| ,query=None | |||
| ,request_params=None | |||
| ,large_response_settings_dict=self.S3_settings_dict) | |||
| generate_manifest = False | |||
| accepted_s3_domains = ["hm-api-responses.s3.amazonaws.com"] | |||
There was a problem hiding this comment.
We shouldn't hardcode this. In search-api's app.cfg there's this AWS_S3_BUCKET_NAME config.
See the review comment below, when we use 303 status code for the check, no longer need this.
src/app.py
Outdated
| if generate_manifest is True: | ||
| content_type = response.content_type | ||
| content_data = response.get_data(as_text=True) | ||
| if content_type.startswith("text/html"): |
There was a problem hiding this comment.
Checking the MIME type of response is not a reliable approach. Instead, use the status code. It'll be 303 when a S3 URL gets returned. This also eliminates the use of AWS_S3_BUCKET_NAME stated above.
src/app.py
Outdated
| if "status" in output_json: | ||
| return output | ||
| if "aggs" in request.json: | ||
| return make_response(jsonify("if parameter produce-clt-manifest is included, may not use 'aggs' in request body."), 422) |
There was a problem hiding this comment.
Capitalize the beginning word "if"
|
|
||
| accepted_s3_domains = ["hm-api-responses.s3.amazonaws.com"] | ||
|
|
||
| manifest_list = [] |
There was a problem hiding this comment.
Due to the fact that multiple search endpoints use the same handling for manifest file generation, we should create a shared method rather than repeating the code.
…, normalized some capitalization, use status codes 303 instead of checking content type
…y_type is returned by the query
yuanzhou
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.