Update for new bin2o configuration #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstene1ns
reviewed
Jan 13, 2021
There was a problem hiding this comment.
Unfortunately this can lead to race conditions when using multiple build jobs.
The default Makefiles have been changed to introduce a dependency on these .h files.
See also dborth/snes9xgx#930 and maybe devkitPro/wii-examples@27445c5 for reference.
|
Thank you for the review! I've adopted |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of devkitPro r37,
bin2ogenerates headers for files directly. This commit favors those generated headers and updates the makefile accordingly, fixing #27.Additionally, a minimal
.gitignorehas been included to avoid accidentally committing objects :)