-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce usage of "any" #448
Conversation
7cbfd1a
to
383a962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice change
@demetris-manikas I'm thinking we should also look at simplifying |
Definitely. Still it proved a non trivial change. |
@demetris-manikas I thought I had accidently marked this as draft and switched it back. Did you mean to switch this? |
I converted this to daft cause after rebasing to the latest code it gives me some linting errors. |
OK I was going to merge but I'll wait for you to address the linter issues. Sorry for the confusion |
f8f0b1f
to
b02d6a6
Compare
@demetris-manikas please let me know when you're ready for me to merge this |
No problem. These things happen all the time |
I updated the packages and the linting errors vanished. |
I opened #458 to track updating the linter |
This reverts commit 8f1b5d4 as it included breaking API changes. It caused numerous failures on our demo applications and in our staging environment and cannot be released in its current state. The changes in that PR are good, but we need to introduce them gradually and carefully (likely in multiple smaller PRs) and verify they don't cause regressions.
This PR aims to reduce the usage of
any
in the codebase