Support for multiple dbos app files in NextJs App #700
Conversation
| @@ -45,7 +45,8 @@ class dbosWorkflowClass { | |||
| // This code needs to execute at least once to launch the DBOS runtime | |||
| // Do not delete this code | |||
| if (process.env.NEXT_PHASE !== "phase-production-build") { | |||
| await DBOS.launch(); | |||
| await DBOS.register(dbosWorkflowClass); | |||
There was a problem hiding this comment.
Is there no longer any need for DBOS.launch()?
There was a problem hiding this comment.
Not in NextJs. register calls launch.
But we do need to run the launch method once
There was a problem hiding this comment.
This is having classes registered after launch. This is guaranteed to not be 100% working at the moment...
| @@ -147,9 +147,27 @@ export class DBOS { | |||
| set(conf, key, newValue); | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| static async register(cls: any) { | |||
There was a problem hiding this comment.
How do this and launch relate? Does launch do things that this doesn't? When do you need both or just one?
There was a problem hiding this comment.
Register registers one class.
Launch intializes various things in the runtime like http, loggers, db connections etc. It does have some registration code that needs to be refactored out imho.
Launch needs to be called only once.
Register needs to be called once per file. Register calls launch because someone has to call launch but launch wll run only once
There was a problem hiding this comment.
Got it! And is it okay if launch runs before all registers are done?
There was a problem hiding this comment.
Yes. Because we explicitly register again
|
I want time to finish exploring a different approach. |
|
"A different approach" == "the one on the chuck/next branch". |
No description provided.