Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to embedded-hal-1.0.0-alpha.1 #33

Closed
wants to merge 3 commits into from

Conversation

eldruin
Copy link
Contributor

@eldruin eldruin commented Jun 18, 2020

Here the adaptions necessary for embedded-hal 1.0.0-alpha.1.

@dbrgn
Copy link
Owner

dbrgn commented Jun 19, 2020

Thanks! I think requiring Rust >=1.34 would be fine, what do you think?

@eldruin
Copy link
Contributor Author

eldruin commented Jun 19, 2020

Good point. The MSRV in embedded-hal had to be raised to Rust 1.35 due to an issue with associated constants in the ADC trait. So far that will be the MSRV of embedded-hal 1.0.0 so actually I would say the MSRV of this crate should be raised to 1.35 as well.
I will revert the commit adding void, update the MSRV and bump the minor version of this crate in this branch.

@dbrgn
Copy link
Owner

dbrgn commented Jun 19, 2020

Makes sense!

@eldruin
Copy link
Contributor Author

eldruin commented Jun 19, 2020

Done :)

@ryankurte
Copy link
Collaborator

ryankurte commented Jun 19, 2020

Looks good! Blocked on rust-embedded/embedded-hal#177 (which I've been mentioning everywhere useful so we have a list of pending PRs when we ship v1.0.0)

@dbrgn
Copy link
Owner

dbrgn commented Dec 22, 2021

@niclashoyer updated your branch to the latest alpha, so let's continue this discussion in #39.

@dbrgn dbrgn closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants