Swift3.1 linux #37
Merged
Swift3.1 linux #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lightsprint09
commented
Apr 3, 2017
•
lightsprint09
commented
- Fixes Swift 3.1 warnings
- Upgrades Swift Lint to 0.17
- compiles now on linux. Tests need to be updated for linux - see Testing on Linux #38
Codecov Report
@@ Coverage Diff @@
## develop #37 +/- ##
===========================================
- Coverage 87.34% 83.83% -3.51%
===========================================
Files 37 20 -17
Lines 1027 297 -730
===========================================
- Hits 897 249 -648
+ Misses 130 48 -82
Continue to review full report at Codecov.
|
dennispost
requested changes
Apr 4, 2017
Source/DBNetworkStackError.swift
Outdated
| @@ -89,7 +89,7 @@ extension DBNetworkStackError : CustomDebugStringConvertible { | |||
| case .requestError(let error): | |||
| return "Request error: \(error)" | |||
| case .serverError(let response, let data): | |||
| return "Server error: \(response), response: ".appendingContentsOf(data: data) | |||
| return "Server error: \(String(describing: response)), response: ".appendingContentsOf(data: data) | |||
There was a problem hiding this comment.
String describing returns optional type description like "optional("response text")"..
Source/URLSessionNetworkAccess.swift
Outdated
| @@ -34,7 +34,7 @@ extension URLSession: URLSessionProtocol {} | |||
|
|
|||
| extension URLSessionDataTask: NetworkTaskRepresenting { | |||
| public var progress: Progress { | |||
| let totalBytesExpected = response?.expectedContentLength ?? NSURLSessionTransferSizeUnknown | |||
| let totalBytesExpected = response?.expectedContentLength ?? -1 | |||
There was a problem hiding this comment.
Can we use of NSURLSessionTransferSizeUnknown instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.