-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: splitup the policy creation if too many parameters are created … #1050
Conversation
…for one policy Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com>
Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
=======================================
Coverage 75.70% 75.70%
=======================================
Files 3 3
Lines 354 354
=======================================
Hits 268 268
Misses 49 49
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I would like to test a prebuild version now, to check if it work's like expected. |
Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com>
I sucessfully deploy this fixed version with 120 parameters. The policy was split up in 2,5 managed policys. |
Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com>
When creating a large set of parameters the maxium policy size of is exceeded:
This PR improves the parameter policy creation by splitting up the policy, if it would exceed the maximum policy size.
Additionally the property
keySeperator
was renamed tokeySeparator
to matchflattenSeparator
.