Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to dbt core v1.4.0 #134

Merged
merged 17 commits into from
Feb 6, 2023
Merged

chore: upgrade to dbt core v1.4.0 #134

merged 17 commits into from
Feb 6, 2023

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Jan 30, 2023 •
edited
Loading

Description

This PR should cover this #136 also include python 3.11 to the matrix, doing so we know that we support the adapter with python 3.11

I tested with multiple models:

  • parquet table
  • parquet incremental and with partitions
  • iceberg table
  • iceberg append
  • iceberg merge

TODO

Notes

  • Somehow the caplog.text is not working anymore therefore tests are half broken

Checklist

  • You followed contributing section
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 marked this pull request as draft January 30, 2023 10:11
@nicor88 nicor88 added the dependencies Pull requests that update a dependency file label Jan 30, 2023
@nicor88 nicor88 marked this pull request as ready for review February 2, 2023 07:42
@nicor88 nicor88 changed the title chore: use dbt core 1.4.x chore: upgrade to dbt core 1.4 Feb 3, 2023
@nicor88 nicor88 changed the title chore: upgrade to dbt core 1.4 chore: upgrade to dbt core v1.4.0 Feb 3, 2023
Jrmyy
Jrmyy previously approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@Jrmyy Jrmyy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Weird stuff about exceptions and logging, I might not see everything but it seems harder to use in 1.4 than in 1.3 🤔

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
tests/unit/test_adapter.py Show resolved Hide resolved
@nicor88 nicor88 requested a review from Jrmyy February 6, 2023 10:36
@nicor88 nicor88 merged commit f5d8cc8 into main Feb 6, 2023
@nicor88 nicor88 deleted the chore/bump_dbt_core branch February 6, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jrmyy Jrmyy Jrmyy approved these changes

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

@thenaturalist thenaturalist Awaiting requested review from thenaturalist

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicor88 @Jrmyy