Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change default table_type in cast_timestamp macro #484

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: change default table_type in cast_timestamp macro #484

merged 1 commit into from
Nov 2, 2023

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Nov 2, 2023

Description

We have a table_type glue. But only table type: hive and iceberg are supported.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 self-assigned this Nov 2, 2023
@nicor88 nicor88 added type:bug Something isn't working enable-functional-tests labels Nov 2, 2023
@nicor88 nicor88 merged commit c5b2b46 into main Nov 2, 2023
@nicor88 nicor88 deleted the fix/type_in_macro branch November 2, 2023 11:42
@nicor88 nicor88 mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jrmyy Jrmyy Jrmyy approved these changes

@svdimchenko svdimchenko svdimchenko approved these changes

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

Assignees

@nicor88 nicor88

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicor88 @Jrmyy @svdimchenko