fix: avoid deleting S3 location because listing relations continues on error #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiro-o918
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88 and
svdimchenko
as code owners
nicor88
reviewed
Apr 24, 2024
nicor88
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Looks good, small comment https://github.com/dbt-athena/dbt-athena/pull/629/files#r1577637980
nicor88
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
list_relations_without_cachingcontinues even when an error occurs when paginating tables.As a result, this function returns
relationsbefore collecting all the tables in a Glue database.To avoid this, build full pagination before collecting tables in the loop.
Also, catch more precise errors about
ClientException.Models used to test - Optional
Checklist