New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tox-based Integration Testing Support #111

Merged

emmyoop merged 9 commits into main from standardize_integration_tests

Oct 15, 2024

Contributor

peterallenwebb commented Oct 10, 2024 •

edited by emmyoop

Loading

Resolves: #109

Checklist

I have verified that these changes work locally
I have updated the README.md (if applicable)
I have added tests & descriptions to my models (and macros if applicable)

peterallenwebb added 8 commits

October 10, 2024 13:27


          Standardize integration tests.

9abd715


          Move profiles file.

a292ed4


          Update config, remove extra profiles file.

e68fec2


          Remove old sample profiles YAML. Modify conifg accordingly.

7e35e73


          Tweak CircleCI config again.

61e586d


          One more try tweaking config.


          Another tweak.

e2a8d2d


          Add back other adapter profiles.

5c830fd

emmyoop reviewed

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

emmyoop reviewed

View reviewed changes

integration_tests/.env/postgres.env Outdated Show resolved Hide resolved

emmyoop reviewed

View reviewed changes

supported_adapters.env Outdated Show resolved Hide resolved

emmyoop reviewed

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

emmyoop reviewed

View reviewed changes

Member

emmyoop left a comment

Looks to me that this covers everything to get postgres tests working! Just some nits on adding empty lines at the end of the files.

I'd like to get approval from a repo owner before merging.

emmyoop requested review from joellabes and graciegoheen

October 10, 2024 21:04

joellabes approved these changes

View reviewed changes

Contributor

joellabes left a comment

lgtm!


          Apply suggestions from code review

9b2b210

emmyoop merged commit 6499107 into main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet