added unique_key to the test_docs_generate places relevant to changes… #114
Conversation
… made in core, TODO: double check that any other references to unique_key in bigquery there are two more on that file need to be changed to None value as well, and design an integration test
… values, failing now due to being unequal
…ental model now only have to fine tune till assertions are correct
…nts back to core pr to initial contributor issue/pr
…ma_tests after pair coding with kyle, similiar test in vain to my previous version which is still in code but is using modified prexisting test functionality which seems a much cleaner simple test
…query into mcknight/CT-116
|
Eventually, we'll want to reconcile the integration test case added here, with the ones added in dbt-labs/dbt-snowflake#96, the one needed in dbt-labs/dbt-spark#291, and the ones we'll need when resolving dbt-labs/dbt-core#4738. They're all testing the same functionality, from the end user's point of view. Our new testing framework must give us the ability to apply those same test cases, across all our repositories, with zero copy/paste. Happy to talk more about this. I'm going to remove myself from code review — let me know if you have any specific questions / things you want me to look at! |
…s to be around models using ::date will fix tomorrow
…patterns from seeds, created a new class to cut down on runs of a test that was being inherited
tests/integration/incremental_schema_tests/test_incremental_schema.py
Outdated
Show resolved
Hide resolved
|
Just logging for posterity that Matt and I should be syncing up Tuesday this week to collate all test changes once we have some confirmation on what code changes need to be made to my Snowflake version of this PR. We all luck, we'll have an approval on this then! |
|
I'm going to approve this because we adapted my code which was thoroughly vetted by Kyle and Chenyu and I believe Leah herself! The snowflake tests were merged, so we'll merge this as well. |
dbt-labs#114) * added unique_key to the test_docs_generate places relevant to changes made in core, TODO: double check that any other references to unique_key in bigquery there are two more on that file need to be changed to None value as well, and design an integration test * init attempt at test, for unique key, getting type error for hashable currently * moved to using basic hash method, and changing up calls and saving of values, failing now due to being unequal * fixed minor errors have all models building properly including incremental model now only have to fine tune till assertions are correct * remove items from docs_generate.py objects to move to secondary pr * using assertTableEqual * added new models and test for single unique key * adding tests for single unique key, and removing unused import * removing import * add first draft for changelog which links to bigquery issue which points back to core pr to initial contributor issue/pr * working on new version of unique_key as list test in incremental_schema_tests after pair coding with kyle, similiar test in vain to my previous version which is still in code but is using modified prexisting test functionality which seems a much cleaner simple test * comments and docstring addition * beginning transition to unify tests between adapters, only issue seems to be around models using ::date will fix tomorrow * applied castings to expected tables as bigquery auto detects certain patterns from seeds, created a new class to cut down on runs of a test that was being inherited * minor fixes * minor naming changes and removal of file from older tests * updates implementing mila final versions to remain similar * removing unnecessary line
… made in core, TODO: double check that any other references to unique_key in bigquery there are two more on that file need to be changed to None value as well, and design an integration test
resolves #112
Description
making changes to be in line with changes to dbt-core regarding use of lists in unique_key values. #4618
Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.