Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve nicely formatted timeout exception (#1187) #1194

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Preserve nicely formatted timeout exception (#1187) #1194

merged 1 commit into from
Apr 24, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

  • use dynamic schema in test_grant_access_to.py

  • use dynamic schema in test_grant_access_to.py

  • revert setup

  • Add descriptive error message on query timeout

  • Add descriptive error message on query timeout

(cherry picked from commit b62ce74)

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt
Preserve nicely formatted timeout exception (#1187)
9980657 
* use dynamic schema in test_grant_access_to.py

* use dynamic schema in test_grant_access_to.py

* revert setup

* Add descriptive error message on query timeout

* Add descriptive error message on query timeout

(cherry picked from commit b62ce74)
@cla-bot cla-bot bot added the cla:yes label Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@martynydbt martynydbt self-requested a review April 24, 2024 16:57
@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Apr 24, 2024
@colin-rogers-dbt colin-rogers-dbt merged commit 642dd73 into 1.7.latest Apr 24, 2024
64 of 67 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the backport-1187-to-1.7.latest branch April 24, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martynydbt martynydbt martynydbt approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @martynydbt