Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'integration' with 'functional' in CONTRIBUTING.md #1357

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Replace 'integration' with 'functional' in CONTRIBUTING.md #1357

merged 6 commits into from
Oct 18, 2024

Conversation

syou6162
Copy link
Contributor

resolves N/A

Problem

The link to integration tests in CONTRIBUTING.md is broken.

Solution

Replace 'integration' with 'functional' in CONTRIBUTING.md. Same as dbt-labs/dbt-snowflake#423.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 28, 2024
@syou6162 syou6162 marked this pull request as ready for review September 28, 2024 18:18
@syou6162 syou6162 requested a review from a team as a code owner September 28, 2024 18:18
@syou6162
Copy link
Contributor Author

syou6162 commented Oct 2, 2024

@colin-rogers-dbt @VersusFacit Could you review this pull request?

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Oct 11, 2024
@mikealfare mikealfare self-assigned this Oct 11, 2024
@mikealfare
Copy link
Contributor

Thanks @syou6162!

@mikealfare mikealfare merged commit d4be89a into dbt-labs:main Oct 18, 2024
36 checks passed
@syou6162 syou6162 deleted the fix/update_contributing_functional branch October 19, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes ok to test Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syou6162 @mikealfare