Using information schema #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added
the
ready_for_review
Closed
2 tasks
|
currently running into the same issue and found this PR, looks like there are conflicts in this branch. |
sungchun12
reviewed
Oct 6, 2022
| @@ -473,8 +473,17 @@ def test_replace(self): | |||
| relation = BigQueryRelation.from_dict(kwargs) | |||
| info_schema = relation.information_schema() | |||
|
|
|||
| tables_schema = info_schema.replace(information_schema_view='__TABLES__') | |||
| assert tables_schema.information_schema_view == '__TABLES__' | |||
| tables_schema = info_schema.replace(information_schema_view='INFORMATION_SCHEMA.TABLES') | |||
There was a problem hiding this comment.
TABLE_STORAGE is also needed for multi-region BigQuery setups as illustrated in this macro workaround this PR is solving for natively: https://github.com/GeneralMills/gmi_common_dbt_utils/blob/main/macros/bq_catalog.sql#L51
|
@hassan-mention-me Any updates on this? |
|
This is something General Mills is also interested in seeing |
|
Closing this in favor of getting #364 over the line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #113 #113
Using
information_schemainstead of TABLES to fetch catalog data, which limits access level needed to generate DBT docs.Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.