Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating passenv in tox #411

Merged
merged 3 commits into from
Dec 7, 2022
Merged

updating passenv in tox #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8ba0ab
fixing env write out in tox due to 4.0.0 release
McKnight-42 Dec 7, 2022
6e9e408
finish tox alignment and add changelog
McKnight-42 Dec 7, 2022
2066792
Merge branch 'main' into mcknight/fix-env
McKnight-42 Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changes/unreleased/Under the Hood-20221207-151813.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
kind: Under the Hood
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably doesn't need a changelog entry, since it's not a change to code we actually release/distribute — but it's nbd

body: fix issue with tox 4.0.0 release which changes passenv syntax for space-separated
variables
time: 2022-12-07T15:18:13.996118-06:00
custom:
Author: McKnight-42
Issue: "411"
PR: "411"
10 changes: 8 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ envlist = py37,py38,py39,py310
[testenv:{unit,py37,py38,py39,py310,py}]
description = unit testing
skip_install = true
passenv = DBT_* PYTEST_ADDOPTS
passenv =
DBT_*
PYTEST_ADDOPTS
commands = {envpython} -m pytest {posargs} tests/unit
deps =
-rdev-requirements.txt
Expand All @@ -14,7 +16,11 @@ deps =
[testenv:{integration,py37,py38,py39,py310,py}-{bigquery}]
description = adapter plugin integration testing
skip_install = true
passenv = DBT_* BIGQUERY_TEST_* PYTEST_ADDOPTS DATAPROC_* GCS_BUCKET
passenv =
DBT_*
BIGQUERY_TEST_*
PYTEST_ADDOPTS DATAPROC_*
GCS_BUCKET
commands =
bigquery: {envpython} -m pytest {posargs} -m profile_bigquery tests/integration
bigquery: {envpython} -m pytest {posargs} -vv tests/functional --profile service_account
Expand Down