-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bytes_billed
to BigQueryAdapterResponse
#570
Merged
McKnight-42
merged 6 commits into
dbt-labs:main
from
bruno-szdl:feature/adding_bytes_billed_to_adapter_response
Mar 20, 2023
Merged
Add bytes_billed
to BigQueryAdapterResponse
#570
McKnight-42
merged 6 commits into
dbt-labs:main
from
bruno-szdl:feature/adding_bytes_billed_to_adapter_response
Mar 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fleid
added
ready_for_review
Externally contributed PR has functional approval, ready for code review from Core engineering
pr_tracked
labels
Mar 7, 2023
This was referenced Mar 7, 2023
Closed
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
McKnight-42
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like agreat addition not seeing any problems while doing local testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla:yes
ready_for_review
Externally contributed PR has functional approval, ready for code review from Core engineering
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #560
Description
This PR adds the information of
bytes_billed
to the adapter response. This was made to have better monitoring of BQ's costs. (more detailed explanation of bytes_billed in #560).Tests
I tested it in a local project. The
bytes_billed
can be seen in the response of the adapter, and they are different frombytes_processed
in this case because the minimum bytes billed by BQ is 10MB. I just removed some information like model name and profiles directory.Checklist
changie new
to create a changelog entry