Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom containers while using dataproc serverless #650

Closed
wants to merge 4 commits into from

Conversation

bveber
Copy link

@bveber bveber commented Apr 7, 2023

resolves #642

Description

The current implementation only supports the standard spark runtime provided by dataproc serverless which does not allow installation of additional dependencies. The custom container can be defined in the runtime_config that is passed to the dataproc call. It expects an image that exists in Container Registry or Artifact Registry with a naming format like {hostname}/{project-id}/{image}:{tag}.

Checklist

bveber added 2 commits March 31, 2023 21:27
* allow custom containers for dataproc serverless jobs
@bveber bveber requested a review from a team as a code owner April 7, 2023 14:21
@bveber bveber requested a review from nathaniel-may April 7, 2023 14:21
@cla-bot cla-bot bot added the cla:yes label Apr 7, 2023
@ghost
Copy link

ghost commented Jun 26, 2023

This would very valuable for us in making dbt python models feasible in our stack. Are there any unmet requirements for this change to be reviewed? Anything I could contribute to help unblock this?

@bveber
Copy link
Author

bveber commented Jul 8, 2023

@Fleid @nathaniel-may Just bumping this since there seems to be interest in this enhancement beyond myself

Copy link

@alyce-cherre alyce-cherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very eager for this to come out!!!

It'll help us make the case to productionize more of our ML models using dbt/python instead of using native GCP/AWS products

@thumarrushik
Copy link

+1

1 similar comment
@fdiaspp
Copy link

fdiaspp commented Sep 5, 2023

+1

@DouglasNorrgard
Copy link

+1

Very eager. Implementation could be very similar to the new dataproc_batch-config?

@c0nn0rstevens
Copy link

Is there any progress on this? This is something my team would really benefit from. What is still needed for this? Can I help somehow?

Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 14, 2024
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Aug 22, 2024
@ShahbalKhan
Copy link

This feature is quite useful for avoiding managing custom clusters for our pyspark transformations. Would love to have it pushed. Also happy to contribute where required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-427] Add support for custom containers while using dataproc serverless
8 participants