Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for rendering foreign key constraints #698

Merged
merged 6 commits into from
Jun 2, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented May 5, 2023

Updates tests for core PR: dbt-labs/dbt-core#7512

resolves dbt-labs/dbt-core#7417

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@MichelleArk MichelleArk changed the title testing testing constraint rendering fixes May 5, 2023
dev-requirements.txt Outdated Show resolved Hide resolved
@MichelleArk MichelleArk changed the title testing constraint rendering fixes add tests for rendering foreign key constraints May 18, 2023
@MichelleArk MichelleArk marked this pull request as ready for review May 18, 2023 18:46
@MichelleArk MichelleArk requested a review from a team as a code owner May 18, 2023 18:46
@MichelleArk MichelleArk merged commit 389acee into main Jun 2, 2023
@MichelleArk MichelleArk deleted the fix-constraint-rendering branch June 2, 2023 19:35
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-698-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 389aceeff8e8e699c04d132c2c5b7af4c514c22c
# Push it to GitHub
git push --set-upstream origin backport-698-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-698-to-1.5.latest.

MichelleArk added a commit that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2519] [CT-2442] [Bug] Foreign key constraint templating
2 participants