Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #688 to 1.5.latest #701

Merged
merged 4 commits into from
May 9, 2023
Merged

Backport #688 to 1.5.latest #701

merged 4 commits into from
May 9, 2023

Conversation

nssalian
Copy link
Contributor

@nssalian nssalian commented May 8, 2023 •
edited
Loading

resolves #687
backport of the PR: #688

Description

Checklist

@nssalian nssalian requested a review from a team as a code owner May 8, 2023 23:35
@nssalian nssalian requested a review from VersusFacit May 8, 2023 23:35
@cla-bot cla-bot bot added the cla:yes label May 8, 2023
@nssalian nssalian changed the title Backport 688 to 1.5.latest Backport #688 to 1.5.latest May 8, 2023
VersusFacit
VersusFacit approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it passes

@nssalian
Copy link
Contributor Author

nssalian commented May 8, 2023 •
edited
Loading

Thanks @VersusFacit. Fixing a missed piece in the test
Just want to call out that the other non-backport changes are black formatting.

@nssalian nssalian merged commit dd02f1a into 1.5.latest May 9, 2023
@nssalian nssalian deleted the backport-688-to-1.5.latest branch May 9, 2023 01:55
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Jun 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nssalian @VersusFacit