Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test constraint rendering with column quoting #713

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Test constraint rendering with column quoting #713

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d87870
Test core 7537
jtcohen6 May 11, 2023
2c86895
Merge branch 'main' into jerco/test-core-7537
MichelleArk Jun 6, 2023
00d9680
Merge branch 'main' into jerco/test-core-7537
MichelleArk Jun 8, 2023
480bd66
Merge branch 'main' into jerco/test-core-7537
MichelleArk Jun 12, 2023
4765378
revert dev-requirements.txt changes
MichelleArk Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@jerco/7370-model-contracts-respect-quoting#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@jerco/7370-model-contracts-respect-quoting#egg=dbt-tests-adapter&subdirectory=tests/adapter

# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
Expand Down
32 changes: 32 additions & 0 deletions tests/functional/adapter/test_constraints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
BaseIncrementalConstraintsRuntimeDdlEnforcement,
BaseIncrementalConstraintsRollback,
BaseModelConstraintsRuntimeEnforcement,
BaseConstraintQuotedColumn,
)
from dbt.tests.adapter.constraints.fixtures import (
my_model_sql,
Expand All @@ -18,8 +19,10 @@
my_model_wrong_name_sql,
my_model_view_wrong_name_sql,
my_model_incremental_wrong_name_sql,
my_model_with_quoted_column_name_sql,
model_schema_yml,
constrained_model_schema_yml,
model_quoted_column_schema_yml,
model_fk_constraint_schema_yml,
my_model_wrong_order_depends_on_fk_sql,
foreign_key_model_sql,
Expand Down Expand Up @@ -209,3 +212,32 @@ def expected_sql(self):
) as model_subq
);
"""


class TestBigQueryConstraintQuotedColumn(BaseConstraintQuotedColumn):
@pytest.fixture(scope="class")
def models(self):
return {
"my_model.sql": my_model_with_quoted_column_name_sql,
"constraints_schema.yml": model_quoted_column_schema_yml.replace("text", "string"),
}

@pytest.fixture(scope="class")
def expected_sql(self):
return """
create or replace table <model_identifier> (
id integer not null,
`from` string not null,
date_day string
)
options()
as (
select id, `from`, date_day
from (
select
'blue' as `from`,
1 as id,
'2019-01-01' as date_day
) as model_subq
);
"""