Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more github deprecations fixes #714

Merged
merged 3 commits into from
May 15, 2023
Merged

more github deprecations fixes #714

merged 3 commits into from
May 15, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented May 12, 2023

resolves #678

Description

Updates version of changie_bot action and triage labeler.

Checklist

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label May 12, 2023
@cla-bot cla-bot bot added the cla:yes label May 12, 2023
@emmyoop emmyoop marked this pull request as ready for review May 12, 2023 16:59
@emmyoop emmyoop requested a review from a team as a code owner May 12, 2023 16:59
@emmyoop emmyoop requested review from Fleid, a team, aranke, davidbloss and VersusFacit and removed request for a team and Fleid May 12, 2023 16:59
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -49,7 +49,7 @@ jobs:
- name: Create and commit changelog on bot PR
if: "contains(github.event.pull_request.labels.*.name, ${{ matrix.label }})"
id: bot_changelog
uses: emmyoop/changie_bot@v1.0
uses: emmyoop/changie_bot@v1.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fork this and use the dbt-labs version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to start a bigger conversation on this topic but leave this as is for now.

@emmyoop emmyoop merged commit 495566a into main May 15, 2023
@emmyoop emmyoop deleted the er/github-deprecations branch May 15, 2023 14:29
@emmyoop emmyoop mentioned this pull request Jun 5, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-488] replace all instances of set-output and node16
3 participants